Improve tests, correctly trigger warnings, and fix output markdown format #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
improve-tests
branch
from
b7fab5f to
105cd6c
Compare
baronfel
approved these changes
Oct 24, 2024
|
What's the |
It's something fiddly: it's the source you want to set up the nuget.config for your new test folder, but it seemed that if you have it in the pipeline then it can't restore from nuget.org. See https://github.com/ionide/KeepAChangelog/actions/runs/11494434344/job/31991923809#step:6:206 I thought it was going to be a series of pipeline fixes that I'd squash after but then it worked with one edit... |
|
Ok, so this is good and you have no more WIP for it? |
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
WHY
Tests are good.
This makes it easier for next steps: probably actually addressing the low-hanging fruit issues, binlog parsing tests, and formatting.